fix(catalog,manifest): handle some ignored errors #670
+27
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also enable errcheck linter for future. Ignore table printer errors for cli which are self observable and mostly fine. Ignoring it in tests. There are many violations, could be enabled separately if needed. Signed-off-by: ferhat elmas <[email protected]>
ferhatelmas
force-pushed
the
handle-more-errors
branch
from
eb82257 to
9ddcab7
Compare
ferhatelmas
changed the title
zeroshade
reviewed
Jan 9, 2026
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
just a couple questions, but otherwise looks good
zeroshade
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enable errcheck linter for future.
Ignore table printer errors for cli which are
self observable and mostly fine. Ignoring it
in tests. There are many violations, could be
enabled separately if needed.